Ticket #52 (closed defect: fixed)

Opened 8 months ago

Last modified 6 weeks ago

Small patch to build FluidSynth 1.0.9 on Solaris

Reported by: laurent Owned by: diwic
Priority: major Milestone:
Component: libfluidsynth Version: 1.0
Keywords: solaris Cc:

Description

FluidSynth doesn't build out of the box on Solaris/OpenSolaris.

The rather trivial patch attached make it work.

As far as I can tell, it then works very well with ScummVM.

Attachments

fluidsynth-1.0.9_solaris_build.patch (0.9 KB) - added by laurent 8 months ago.
Patch to build FluidSynth 1.0.9 on Solaris

Change History

Changed 8 months ago by diwic

Thanks for submitting this patch! However, your patch includes a change to the configure file, which is automatically generated by the script "autogen.sh" and the file "configure.ac" (and possibly more files?). That means that even if your patch is applied it will be overwritten the next time anybody runs autogen.sh. Is it possible for you rewrite the patch so that it changes other files instead of the configure file?

Changed 8 months ago by diwic

By the way, if you run the autogen script on your machine, will it make a correct configure script? And just for the record, what version of Solaris/OpenSolaris are you running?

Changed 8 months ago by laurent

Good point, sorry, I'm still not very proficient with the autotools.

Here's a new version of the patch that modifies configure.ac instead of configure. After running autogen.sh, it configures and builds ok. without that patch, the generated configure won't work. I've tested it on Both Solaris 10 10/08 and OpenSolaris? 2009.06 (actually, having to add "-lnsl -lsocket" is *very* common on all Solaris versions).

Changed 8 months ago by laurent

Patch to build FluidSynth 1.0.9 on Solaris

Changed 8 months ago by diwic

It's great that we've found a way to build 1.0.9 on Solaris, I have added this information to the Wiki for now.

I was going to commit it into current SVN but since 1.0.9, FluidSynth has started to depend on GLib, so the situation has changed slightly. Would it be possible for you to investigate whether the patch is still needed in the current SVN version? Thanks in advance!

Changed 8 months ago by laurent

The SVN version won't build out-of-the-box, because those options have been added, which are not supported by Solaris' ld:

src/Makefile.am:fluidsynth_LDFLAGS = -Wl,--as-needed src/Makefile.in:fluidsynth_LDFLAGS = -Wl,--as-needed

They should be used only if GNU's ld is detected,

Once removed, it also needs configure modified in the same way to build, but not fluidsynth_priv.h anymore.

Changed 8 months ago by diwic

  • owner changed from unassigned to diwic
  • status changed from new to assigned

I've committed changes to configure.ac and Makefile.am to SVN now (r204). Can you check if it builds correctly now?

Changed 8 months ago by laurent

I had to run "automake --add-missing" to get Makefile.in, as well as autogen.sh, it then configured and built without problem, thanks :-)

Changed 8 months ago by diwic

  • status changed from assigned to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.